Add support for google_oracle_database_cloud_exadata_infrastructure_exascale_config#18002
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
d715fb7 to
65fdc44
Compare
|
@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label |
65fdc44 to
2f9ad7f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2f9ad7f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @virgulati2003, @slevenick VCR tests complete for 2f9ad7f! |
|
@slevenick Gentle reminder as this has been out for review for close to a week now. Thanks |
2f9ad7f to
5732d2c
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5732d2c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @virgulati2003, @slevenick VCR tests complete for 5732d2c! |
| include_project: true | ||
|
|
||
| custom_code: | ||
| custom_delete: templates/terraform/custom_delete/only_remove_from_state.go.tmpl |
There was a problem hiding this comment.
Is there a way to "delete" or reset the value to default?
There was a problem hiding this comment.
Oracle currently doesn't provide functionality to deconfigure exascale storage on an exadata infrastructure. Since the api does not support deletion/reset for Exascale configurations, which is why only_remove_from_state is used.
There was a problem hiding this comment.
Can you add a note to that effect in the description of the resource? Just to make sure people know that deleting this resource doesn't actually change or remove the exascale config
5732d2c to
d8e85f7
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d8e85f7: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @virgulati2003, @slevenick VCR tests complete for d8e85f7! |
d8e85f7 to
d663d70
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d663d70: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @virgulati2003, @slevenick VCR tests complete for d663d70! |
fdf73a1
Description
This PR adds support for a new resource
google_oracle_database_cloud_exadata_infrastructure_exascale_configto configure Exascale storage on an Oracle Cloud Exadata Infrastructure in Google Cloud.This resource triggers a one-time setup action using the
configureExascalePOST method on thecloudExadataInfrastructuresAPI endpoint. Deleting the resource removes it from the Terraform state without affecting the underlying infrastructure.Fixes hashicorp/terraform-provider-google#27921
Release Note