Skip to content

Add support for google_oracle_database_cloud_exadata_infrastructure_exascale_config#18002

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-exascale-config
Jun 25, 2026
Merged

Add support for google_oracle_database_cloud_exadata_infrastructure_exascale_config#18002
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-exascale-config

Conversation

@virgulati2003

@virgulati2003 virgulati2003 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds support for a new resource google_oracle_database_cloud_exadata_infrastructure_exascale_config to configure Exascale storage on an Oracle Cloud Exadata Infrastructure in Google Cloud.

This resource triggers a one-time setup action using the configureExascale POST method on the cloudExadataInfrastructures API endpoint. Deleting the resource removes it from the Terraform state without affecting the underlying infrastructure.

Fixes hashicorp/terraform-provider-google#27921

Release Note

`google_oracle_database_cloud_exadata_infrastructure_exascale_config` 

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 18, 2026
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from slevenick June 18, 2026 06:40
@github-actions

Copy link
Copy Markdown

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-exascale-config branch from d715fb7 to 65fdc44 Compare June 24, 2026 09:49
@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-exascale-config branch from 65fdc44 to 2f9ad7f Compare June 24, 2026 11:45
@modular-magician modular-magician added service/oracledatabase and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 24, 2026
@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2f9ad7f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 765 insertions(+)
google-beta provider View Diff 4 files changed, 765 insertions(+)
terraform-google-conversion View Diff 1 file changed, 125 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 122 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
46 43 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseCloudExadataInfrastructureExascaleConfig_oracledatabaseCloudExadataInfrastructureExascaleConfigBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccOracleDatabaseCloudExadataInfrastructureExascaleConfig_oracledatabaseCloudExadataInfrastructureExascaleConfigBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @slevenick VCR tests complete for 2f9ad7f!

@virgulati2003

Copy link
Copy Markdown
Contributor Author

@slevenick Gentle reminder as this has been out for review for close to a week now. Thanks

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-exascale-config branch from 2f9ad7f to 5732d2c Compare June 24, 2026 18:14
@modular-magician

modular-magician commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5732d2c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 765 insertions(+)
google-beta provider View Diff 4 files changed, 765 insertions(+)
terraform-google-conversion View Diff 1 file changed, 125 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 122 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
46 44 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@virgulati2003, @slevenick VCR tests complete for 5732d2c!

Comment thread mmv1/products/oracledatabase/CloudExadataInfrastructureExascaleConfig.yaml Outdated
Comment thread mmv1/products/oracledatabase/CloudExadataInfrastructureExascaleConfig.yaml Outdated
Comment thread mmv1/products/oracledatabase/CloudExadataInfrastructureExascaleConfig.yaml Outdated
include_project: true

custom_code:
custom_delete: templates/terraform/custom_delete/only_remove_from_state.go.tmpl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to "delete" or reset the value to default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle currently doesn't provide functionality to deconfigure exascale storage on an exadata infrastructure. Since the api does not support deletion/reset for Exascale configurations, which is why only_remove_from_state is used.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note to that effect in the description of the resource? Just to make sure people know that deleting this resource doesn't actually change or remove the exascale config

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-exascale-config branch from 5732d2c to d8e85f7 Compare June 25, 2026 17:26
@github-actions github-actions Bot requested a review from slevenick June 25, 2026 17:26
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d8e85f7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 776 insertions(+)
google-beta provider View Diff 4 files changed, 776 insertions(+)
terraform-google-conversion View Diff 1 file changed, 125 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 122 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
46 44 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@virgulati2003, @slevenick VCR tests complete for d8e85f7!

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-exascale-config branch from d8e85f7 to d663d70 Compare June 25, 2026 20:36
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d663d70:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 779 insertions(+)
google-beta provider View Diff 4 files changed, 779 insertions(+)
terraform-google-conversion View Diff 1 file changed, 125 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 122 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
46 44 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@virgulati2003, @slevenick VCR tests complete for d663d70!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Resource: google_oracle_database_cloud_exadata_infrastructure_exascale_config

3 participants